Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dhersz Feeds are sometimes nested within directories prior to zipping (and i don't think the specifications actually explicitly forbid this). When that happens, this line also lists the directory as one of the "files"
gtfsio/R/import_gtfs.R
Line 118 in e083a15
That doesn't end in ".txt", and so triggers the warning in the subsequent line. These feeds are nevertheless processed okay, and there is nothing wrong with the code. This PR simply helps to appropriately identify such cases and avoid the warning. It's perhaps not the best way to identify them, so happy to iterate, but allows feeds to be nested at arbitrary depth within the zip archive - let me know if you think of a better way.
I don't have any live examples, but have it on several older versions of the Madrid feed. It seems to have been updated now to the expected flat format, but definitely used to come in a "google-gtfs" directory.